Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add local read benchmarks for PagedBlockStore #16804

Merged
merged 1 commit into from
Feb 21, 2023

Conversation

YangchenYe323
Copy link
Contributor

What changes are proposed in this pull request?

Added benchmarks for PagedBlockStore that read from local storage rather than UFS.

Why are the changes needed?

This piece is missing as PagedBlockStore didn't support creating local blocks then.

Does this PR introduce any user facing changes?

No.

@YangchenYe323
Copy link
Contributor Author

@beinan @dbw9580 Would you like to take a look? Should be pretty quick.

Copy link
Contributor

@dbw9580 dbw9580 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@shangxinli
Copy link
Contributor

Any benchmarking number you can share?

@jiacheliu3
Copy link
Contributor

alluxio-bot, merge this please

@alluxio-bot alluxio-bot merged commit f9cb6df into Alluxio:master Feb 21, 2023
YangchenYe323 added a commit to YangchenYe323/alluxio that referenced this pull request Apr 16, 2023
### What changes are proposed in this pull request?
Added benchmarks for `PagedBlockStore` that read from local storage
rather than UFS.

### Why are the changes needed?
This piece is missing as `PagedBlockStore` didn't support creating local
blocks then.

### Does this PR introduce any user facing changes?
No.

pr-link: Alluxio#16804
change-id: cid-5e0226beb45ae714cae4417c43076f0857cdf7c6
jiacheliu3 pushed a commit to jiacheliu3/alluxio that referenced this pull request May 16, 2023
### What changes are proposed in this pull request?
Added benchmarks for `PagedBlockStore` that read from local storage
rather than UFS.

### Why are the changes needed?
This piece is missing as `PagedBlockStore` didn't support creating local
blocks then.

### Does this PR introduce any user facing changes?
No.

pr-link: Alluxio#16804
change-id: cid-5e0226beb45ae714cae4417c43076f0857cdf7c6
jiacheliu3 pushed a commit to jiacheliu3/alluxio that referenced this pull request May 16, 2023
### What changes are proposed in this pull request?
Added benchmarks for `PagedBlockStore` that read from local storage
rather than UFS.

### Why are the changes needed?
This piece is missing as `PagedBlockStore` didn't support creating local
blocks then.

### Does this PR introduce any user facing changes?
No.

pr-link: Alluxio#16804
change-id: cid-5e0226beb45ae714cae4417c43076f0857cdf7c6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants